3
Jun/10
0

BLOBs, Synonyms, and DBD::Oracle

INSERTing, UPDATEing, and SELECTing LOBs (CLOB/BLOB) in Oracle using Perl can be a PITA. Case in point: 2 years ago a fellow coworker ended up writing some extremely complex code using ora_lob_write(), etc, when all he really needed to do was use bind_param() and declare that the blob column is a blob so that DBD::Oracle would know to treat is specially. At the time I believe he did try something like:

my $sth = $dbh->prepare(q[
    INSERT INTO some_table (color, blob_data)
    VALUES (?, ?)
]);
$sth->bind_param( 1, 'red' );
$sth->bind_param( 2, $data_for_blob, {ora_type => ORA_BLOB } );
$sth->execute();

But then an error like “DBD::Oracle::st execute failed: ORA-04043: object some_table does not exist (DBD SUCCESS: OCIDescribeAny(view)/LOB refetch)” was raised. Which made no sense since some_table is very much an object and any number of SQL operations work on it… when BLOBs are not involved. In the end he ended up having to write code that was triple the size to get around this issue.

So, 2 years later and a little hair pulling, I come to figure out by luck that the problem is that the underlying DBD::Oracle code, that makes dealing with BLOBs simple, fails when you are using a synonym in your insert. All we had to do is fully spell out the table name, and it works!

my $sth = $dbh->prepare(q[
    INSERT INTO some_schema.some_table (color, blob_data)
    VALUES (?, ?)
]);
$sth->bind_param( 1, 'red' );
$sth->bind_param( 2, $data_for_blob, {ora_type => ORA_BLOB } );
$sth->execute();

Hopefully this helps others.

Tagged as: ,
21
May/10
1

Generating Constants in Perl

The other day @ $work I was throwing together a module that creates constants based on a fairly static table in the database. Of course I didn’t want to hard code the contants, I wanted them to be magically created by what was in the database. For the sake of this example I had a table called “toy_categories” where each record has a unique ID (toy_category_id) and a name that can only be letters and underscores. The data would look something like:

ID  NAME
--  --------------
12  dolls
 7  action_figures
92  education

And the resulting constants would look something like this:

TOY_CATEGORY_DOLLS = 12
TOY_CATEGORY_ACTION_FIGURES = 7
TOY_CATEGORY_EDUCATION = 92

If you read the core perl documents you might be lead to think that the constant pragma is the way to go. This is not the case – just because a particular library is distributed with Perl does not mean its a good tool, instead it usually means that the library cannot be removed or substantially modified for backwards-compatibility reasons. In my experience most core libraries are to be avoided – there are much better solutions on CPAN.

So, the CPAN solution to constants is Readonly. This module hooks in to Perl’s ability to mark a variable as read-only, much like how variables can be flagged as tainted or scalars as UTF. Make sure you grab Readonly::XS as well to get the full benefit of read-only variables without the performance hit.

So, if you were to create a module for these constants you might do something like this:

package MyApp::Constants::ToyCategories;
use strict;
use warnings;

use Readonly;
use Exporter qw( import );

our @EXPORT = qw(
    $TOY_CATEGORY_DOLLS
    $TOY_CATEGORY_ACTION_FIGURES
    $TOY_CATEGORY_EDUCATION
);

Readonly our $TOY_CATEGORY_DOLLS => 12;
Readonly our $TOY_CATEGORY_ACTION_FIGURES => 7;
Readonly our $TOY_CATEGORY_EDUCATION => 92;

1;

And then in some module you can access these constants:

use MyApp::Constants::ToyCategories;

if ($toy->category_id() == $TOY_CATEGORY_EDUCATION) {
    my $response = ask_question('Are you an educator?');
}

Now, like I said, I don’t want to hardcode the constants. I want them to be dynamically created by records in my toy_categories table which resides in my database. Its actually pretty simple to do this with some tricky evals:

package MyApp::Constants::ToyCategories;
use strict;
use warnings;

use Readonly;
use Exporter;
use Exporter qw( import );

our @EXPORT;

{
    my $dbh = code_that_returns_a_dbi_handle();
    my $sth = $dbh->prepare(q[
        SELECT toy_category_id, name
        FROM toy_categories
    ]);
    $sth->execute();
    $sth->bind_columns( \my( $id, $name ) );
    while ($sth->fetch()) {
        _export_variable( "toy_category_$name" => $id );
    }
}

sub _export_constant {
    my ($variable, $value) = @_;

    $variable = '$' . uc($variable);

    my ($error, $failed);
    {
        local $@;
        $failed = not eval("Readonly our $variable => \$value");
        $error = $@;
    }
    if ($failed) { die "Unable to create constant $variable: $error"; }
}

1;

What’s going on here? Let’s start at the top:

use Exporter qw( import );

This is the least intrusive way of using exporter and doesn’t pollute your namespace nearly as much as ‘use base qw( Exporter );’ does and is friendlies to other modules.

    my $dbh = code_that_returns_a_dbi_handle();

Replace this with whatever you use to get a DBI database handle. Take a look at DBIx::Connector for a great alternative to doing this directly with DBI.

    my $sth = $dbh->prepare(q[
        SELECT toy_category_id, name
        FROM toy_categories
    ]);
    $sth->execute();
    $sth->bind_columns( \my( $id, $name ) );
    while ($sth->fetch()) {
        ...
    }

I’m a big fan of writing my DBI selects in this fashion with bind_columns() because it tends to be the fastest way to get the data (versus fetchrow_hashref, etc) and tends to lead to the simplest code within the while loop since it just needs to use $id and $name versus $row->{$id} and $row->{name} (for example).

        _export_variable( "toy_category_$name" => $id );

While all of the code within _export_variable() could just be inlined right in the spot, that’s bad design. If you can get a piece of your code generalized and moved to a subroutine, do it.

    $variable = '$' . uc($variable);

Constants should always, due to convention, be uppercase. It is very important that you code to popular conventions because other people will most likely be working on your code later and if you come from a common expectation of how various things are done they will have an easier time ramping up to your code. I try to code to the Modern Perl / CPAN conventions.

    my ($error, $failed);
    {
        local $@;
        $failed = not eval ...;
        $error = $@;
    }
    if ($failed) { ... }

This bit of code was taken from nothingmuch’s blog entry where he announces Try::Tiny which provides a safe way to handle eval errors. Read up there if you want to understand why the code was written this way.

        $failed = not eval("Readonly our $variable => \$value");

While this code is several blocks deep in scope, this constant will exist in the package’s scope since it is being declared with ‘our’.

That’s it. After this was implemented I thought it was so useful, simple, but requiring the knowledge of a few tricks, that I’d share it with ya’all. Enjoy!

Tagged as: ,
12
Apr/10
6

Apache Cassandra and the Thrift API on CPAN

I’m currently playing around with a project that uses Apache Cassandra. The Cassandra website states:

“The Apache Cassandra Project develops a highly scalable second-generation distributed database, bringing together Dynamo’s fully distributed design and Bigtable’s ColumnFamily-based data model.”

So, from what I’ve experienced so far this is either a distributed Berkely DB, or a persistent Memcached, depending on which concept you are more familiar with (I know, that’s incredibly over simplified).

Cassandra was developed by Facebook and was made open source several years ago. It uses the Thrift API to communicate, which was also developed by Facebook. Supposedly there are some steps being taken to move Cassandra on to a different API, but Thrift is the defacto for now.

There are two modules on CPAN that deal with Cassandra. Net::Cassandra is the original, and in my opinion, the superior/simpler/easier module. Net::Cassandra::Easy is a later implementation that really isn’t any simpler from what I can tell and neither seems any more or less tied to the intricacies of the Thrift API despite Net::Cassandra::Easy’s accusations of Net::Cassandra. Both implement the Thrift API under the scenes in their own way, and both are lacking in features.

Now, the Thrift API itself is distributed with a perl library called simply “Thrift”. This library is very new and it shows. It needs a lot of work, a lot of automated tests, and IMO should be on CPAN. I consider it a fail when a project decides to distribute Perl libraries independently from CPAN. This leads to very little exposure – I was lucky I found the perl library in the Thrift tarball, I doubt others have been as lucky.

So, I’d like to make a Thrift driver library and put it on CPAN. Then, a truly Thrift independent Cassandra client library can be written that uses the Thrift library behind the scenes, but is not directly tied in with it. Later, when Cassandra decides to change their API library, the Cassandra library can be changed to use a new driver.

An additional benefit to this is if any Cassandra features are not yet available via the Cassandra module, then the perl developer can easily drop down to the Thrift driver and directly write Thrift queries.

Has anyone thought of this, or perhaps begun working on something like this? If not, I’d like to do it and I’d love to hear any suggestions and thoughts people have.

23
Jan/10
5

Robust DBI Transaction and Connection Handling

Edit: It turns out there is already a module on CPAN that does exactly what I talked about here. Its called DBIx::Connector. I haven’t tried it yet, but it looks like the guy that wrote it designed it with input from the DBIC guys.

I’m a big fan of DBIx::Class. Among DBIC’s many great features is its superb transaction and connection handling via DBIx::Class::Storage::DBI. When I’m using raw DBI I feel like I’m missing these core components. I should always be able to expect robust transaction and connection handling.

I started playing around with creating a new CPAN module (something like DBIx::Robust, DBIx::Transaction, etc…) but each time I dove in to it I kept coming to the conclusion that DBIC’s DBI storage drivers provide everything I need and I would just be shooting myself in the foot by either porting DBIx::Class::Storage::DBI to a DBIC independent API or by writing it from scratch.

Before I go any further, let me show you how attractive and awesome DBIC’s storage layer is:

  • Transactions may be nested, even without savepoints.
  • Transaction savepoints can automatically be tracked allowing for reliable and incremental rollbacks.
  • The appropriate DateTime::Format class is automatically determined based on the type of database.
  • All database calls efficiently pass through a layer that detects stale connections that will attempt to re-connect to a database.

“There is no charge for awesomeness, or attractiveness.”

The DBIx::Class::Storage::DBI pod illustrates all this in a round-about way: “If you set AutoCommit => 0 in your connect info, then you are always in an assumed transaction between commits, and you’re telling us you’d like to manage that manually. A lot of the magic protections offered by this module will go away. We can’t protect you from exceptions due to database disconnects because we don’t know anything about how to restart your transactions. You’re on your own for handling all sorts of exceptional cases if you choose the AutoCommit => 0 path, just as you would be with raw DBI.”

This stuff is really powerful, and we should never have to work with databases in Perl without it. But, currently, it is only meant to work under DBIC, which is a shame. I’m betting that DBIx::Class::Storage::DBI could be used directly, bypassing DBIC completely. There is some DBIC stuff layered in there, but that should be ignorable.

What do the rest of you think? Has anyone considered moving this logic out in to a generic distribution that isn’t DBIC specific? Is there merit in what I’m talking about? Does anyone use DBIx::Class::Storage::DBI directly, bypassing DBIC?

12
Oct/09
0

use HTML::FormHandler;

I’ve been meaning to give HTML::FormHandler a try for quite some time now. Over the weekend I converted a form from some home-grown form validation and html generation to use HTML::FormHandler instead. HTML::FormHandler was inspired by, and quasi-forked from, Form::Processor. There are many options for processing forms, such as FormValidator::Simple (Catalyst’s default) and Data::FormValidator, to name a few.

Up until now I’ve always thought that the existing form handling/validating modules on CPAN were incredibly lacking. They all have these crazy and inconsistent APIs that in the end limit what you are able to do. I don’t expect a form validation API to handle every possible situation, but I do expect it to provide a consistent API that is well documented and allows me to easily extend if I need additional functionality. Plus none of them use Moose (AFAIK), which isn’t just me being a Moose evangelist, its also practical because Moose provides mechanisms to extend functionality via roles and to provide reusable validation with MooseX::Types.

HTML::FormHandler solves these issues. HTML::FormHandler can be a complete end-to-end solution for declaring form fields and types, applying server-side validation, generating the HTML for a form, and applying form submits to the database. Almost everything and the kitchen sink is there, except client-side form validation, which can be added separately of course. Normally a “do everything” package scares me, especially for something like form validation. But, Gerda Shank (the author of HTML::FormHandler) did a great job splitting out the various pieces of HTML::FormHandler so that any piece of the form handling process can be subverted to your own needs, and there is copious amounts of documentation explaining how to do so.

The HTML::FormHandler::Manual::Intro does a great job introducing HTML::FormHandler.

There are a few downsides to this module’s current state. It is relatively new and is still stabilizing. For example, just recently the results of form validation were separated from the form object itself. This is a huge fundamental change, but a necessary one. Also, the concept of widgets was recently introduced. Widgets are a great way to extend and customize the display of form fields, and the form as a whole. But, this was just introduced and is still experimental, and has some rough edges. Despite this, the widget design is very promising and I ended up using it myself (thanks to HTML::FormHandler::Manual::Rendering) as my preferred rendering method.

Enjoy.

9
Sep/09
3

Top 10 Reasons to use Perl

You should use Perl because…

10. Real Perl coders don’t have fohawks.
9. Perl has nothing to do with Ryan Seacrest.
8. Beer improves Perl.
7. It comes with a 20-sided die for all that TIMTOWTDI.
6. It has nothing to do with PHP.
5. Captain Picard writes perl.
4. There is no better place to get Moo seX.
3. It grows on you.
2. IE8 was not written in Perl.

… drum roll …

1. You can write this.

5
Aug/09
0

use Path::Class;

The CPAN (Comprehensive Perl Archive Network) distribution, Path::Class, provides a simple OO API alternative to the built-in perl file IO functions such as open, opendir, stat, etc. Code written to use Path::Class tends to be smaller (concise, easier to maintain, etc) than similar code that uses the standard built-in functions.

Here is an example of how a small utility might be written without Path::Class:

print "Find all files that are less than 10k in size...\n";

my $dir = '/some/dir';
opendir( DIR, $dir );
    my @files = readdir( DIR );
closedir( DIR );

foreach my $file (@files) {
    next if !-f "$dir/$file";
    if ( (stat "$dir/$file")[7] < 1024 * 10) {
        print "$dir/$file\n";
    }
}

And here it is re-written to use Path::Class:

use Path::Class;
print "Find all files that are less than 10k in size...\n";

my $dir = dir('/some/dir');

while (my $file = $dir->next()) {
    next if $file->is_dir();
    if ($file->stat->size() < 1024 * 10) {
        print "$file\n";
    }
}

Using Path::Class is a no-brainer when you compare `(stat "$dir/$file")[7]` with `$file->stat->size()`.

One of Path::Class’s greatest stengths is that it is very simple and many of the features it provides are done so by glueing with other well-tested modules that have been on CPAN for a long time. These modules include IO::Dir, IO::File, File::Path, and File::stat.

Some other highlights include:

  • Has a recurse() method that provides an enhanced File::Find-like interface.
  • Works equally well with absolute and relative paths, and can correctly convert between the two.
  • Symlinks are handled correctly and there are methods to interact with them.
  • Works equally well under different operating systems, such as Linux and Windows.
  • The interface, for me anyway, is about as intuitive as it gets. Very well designed to DWIM.

I’ve been using this module at $work for a while now and am very happy with it and have had coworkers tell me, after they gave it a try, how much cleaner their code ended up being because they used this module.

Enjoy!

Tagged as:
28
Jul/09
2

Upgrading to Catalyst 5.8

Over the last few days at $work I’ve been upgrading Catalyst from 5.7 to 5.8. This new version of catalyst, released in April, has been completely overhauled to use Moose for it’s OO system, among other enhancements and bug fixes.

I found that the Catalyst::Manual::CatalystAndMoose manual was a great starting point to using Moose with Catalyst. Also, Catalyst::Upgrading has specific points to consider when upgrading to 5.8. During the initial install of Catalyst 5.8 I was told that I had a few related modules installed, that while not Catalyst prerequisites, I should upgrade them as they were known to fail on the new Catalyst. I was lucky that I caught this message, as cpan did not pause to wait for me to read it and went on its marry way building, testing, and installing Catalyst.

Once installed I went ahead and also upgraded some related modules we use such as Catalyst::Plugin::Authentication, DBIx::Class, Catalyst::Plugin::Session, Catalyst::Authentication::Store::DBIx::Class, etc. This way I could test all these upgrades all at once instead of one at a time.

Next I modified all my custom plugins to use MRO::Compat instead of Class::C3 per the documentation in Class::C3::Adopt::NEXT. But, then I realized I might as well just rewrite all my plugins as Moose::Roles as its pretty easy to convert a plugin to a role and you end up with much cleaner code.

I started Apache up and things mostly worked. There were a few backwards incompatibilities that I wasn’t aware of, such as there were a few cases where developers had done this:

sub index : Local { }

Instead of:

sub index : Private { }

In our previous version of catalyst (5.7) using :Local, while not documented, worked just like :Private if the subroutine was named index. In 5.8 only :Private will cause a handler named index to be the default handler if the URL resolves to the controller only. This was an easy fix. There were a couple other small issues, but nothing major. I found and fixed a bug in Catalyst::Model::DBIC::Schema and added the support for the compute() method to Catalyst::Plugin::Cache. Both of these changes reduced the amount of changes I needed to make to my own code.

A couple hours in to it I was upgraded and everything was working. Of course I spent the next few days upgrading/enhancing/rewriting Catalyst bits that could be done much more elegantly, and with less code, using Moose.

On a side note, during the upgrade I found this great quote in Catalyst::Model::Adaptor:

Catalyst is glue, not a way of life!

Amen! Most people, myself included, start out by writing all their business logic in their Controllers because that is what MVC told them to do. Don’t do it! Catalyst is meant to be a GLUE – most of your application should be written in a way that it doesn’t give a flying crap how, or by whom, it is used. Put your business logic in modules that optionally expose themselves as Models (perhaps via Catalyst::Model::Adaptor) or just by adding a use statement in your controller that then uses that module. Your controllers should be little more than code to glue a data source with the view and provide some input validation.

I’ve been waiting a long time for this Moosification and its been a joy working with this new Catalyst. Next up to bat will be the Moosification of DBIx::Class! Think we’ll get it by Christmas? :)

Don’t forget to buy the new Catalyst Book! If purchasing from Amazon make sure you follow this link to ensure that the Enlightened Perl Organisation gets a cut of the sale.

20
Jul/09
3

XS Hits Newb; Bystanders Watch in Dismay

Last year I wrote GIS::Distance::Fast to provide some much needed speedups to the pure-perl GIS::Distance. This ::Fast version used Inline::C which isn’t all that optimal and was just a scapegoat for doing the right thing.

So, this evening I rolled up my sleeves and went to work. I first looked at a module I already knew to use XS, Cache::Memcached::Fast. That was overwelming.

Then I went on over and read through the perlxs and perlxstut docs. I was STILL floundering about not sure what to do. I then took a whack at using SWIG (Simplified Wrapper and Interface Generator). OhMyGodz I’m feeling overwhelmed now and still nothing works. I’m not going to even document my attempts up until this point.

I then found this document that goes in to more detail about using SWIG with Perl. The thing about this document that helped me so much is that in section 2, Perl Extension Building, it had the simplest example I had yet run in to, and it made sense! Its kinda funny that a SWIG document was what taught me how to write my own XS without using SWIG. :)

An XS distribution can contain as little as two files (well, beyond the usual Makefile.PL, etc). A single .pm file and a .xs file is enough. You can get more complex, if you want, of course. Once you’ve written your Module.xs file you can run it through xssubpp Module.xs > Module.c to see what the .c file looks like and to verify that your .xs file is correct.

Note that xssubpp may complain about you using types that aren’t in your typemap. This is because xssubpp doesn’t know how to find your system’s typemap file. You can specify a typemap file using the -typemap switch. The file is located somewhere in your perl lib path as ExtUtils/typemap.

So, let’s go for an example. Let’s make an XS module that convert hours to minutes. I structure all my code and files as if they would be distributed as a CPAN module. This has added benefits as you’ll see in a moment.

convert-hoursminutes/lib/Convert/HoursMins.pm:

package Convert::HoursMins;
use strict;
use warnings;

our $VERSION = 0.01;

use XSLoader;

XSLoader::load('Convert::HoursMins', $VERSION);

1;

convert-hoursminutes/HoursMins.xs:

#include "EXTERN.h"
#include "perl.h"
#include "XSUB.h"

double convert_hours_mins( double hours ) {
    return hours * 60;
}

MODULE = Convert::HoursMins  PACKAGE = Convert::HoursMins

PROTOTYPES: DISABLE

double
convert_hours_mins (hours)
    double hours

convert-hoursmins/Makefile.PL

use inc::Module::Install;

name     'Convert-HoursMins';
all_from 'lib/Convert/HoursMins.pm';
requires 'XSLoader';

WriteAll;

convert-hoursmins/t/00_basic.t

use strict;
use warnings;
use Test::More tests => 2;

BEGIN{ use_ok('Convert::HoursMins'); }

is(
    Convert::HoursMins::convert_hours_minutes(1.5),
    90,
    '1.5 hours is 90 minutes',
);

Now lets see if it worked:

perl Makefile.PL
make
make test

Bottom line for me is XS isn’t all that hard when your C code isn’t all that complex. SWIG is overkill for small stuff. But for large swaths of C code I bet SWIG saves lives. Also, XS is a little arcane, but its not too bad.

Tagged as:
15
Jul/09
5

Authoring a CPAN Module

I’ve been authoring CPAN distribution since early 2003 with my first module being Geo::Distance. Since then I’ve authored several other distributions and do my best to keep my RT bug list small and fix FAILs. This process of authoring and maintaining modules on CPAN is in my top-10 list of all-time most educational experiences of my career.

I strongly encourage anyone that wants to become a better developer to take on the task and create a useful distribution for CPAN and/or work on an existing distro. There are plenty of projects out there (such as Moose, DBIx::Class, and Catalyst, to name a few) that need help and can use all the hands that they can get.

Now, if you would instead like to create your own distribution on CPAN, go for it! Its really quite easy and fun. But, it is VERY important that you think long and hard about what you want to release on CPAN. It may seem that every possible task that someone might want to accomplish in Perl is already available on CPAN – this is false. I regularly find myself needing tools that aren’t yet on CPAN. Don’t just write something for the sake of getting something on CPAN – develop something that is useful, of high quality, has a decent suite of automated tests, and doesn’t duplicate a module that is already on CPAN.

Once you developed a module or two, and you are ready to get it out the door, you’ll want to do a couple things. First, create a directory to hold your distribution. Assuming your module is named Acme::Yesterday:

mkdir Acme-Yesterday
cd Acme-Yesterday
vi Makefile.PL

You’ll want to install Module::Install first, before you go any further as it provides a much easier to configure build/test/install process than the old-school ExtUtils::MakeMaker.

Now, your Makefile.PL will look something like this:

use inc::Module::Install::DSL 0.91;
all_from lib/Acme/Yesterday.pm
requires DateTime
test_requires Test::More 0.42

(Notice the first line DOES have a semicolon at the end, while the rest do not)

Next, create a directory to put your module(s):

mkdir lib
mkdir lib/Acme
vi lib/Acme/Yesterday.pm

Now, your module will need some minimum requirements such as declaring the version of the distribution, the license type, and a name. Also, most CPAN modules follow a common convention for documentation using POD. Here is the most minimal of a module:

package Acme::Yesterday;
use strict;
use warnings;

our $VERSION = 0.01;

=head1 NAME

Acme::Yesterday - Make time() return the same hour,
second, and even minute as exactly 24 hours ago!

=head1 SYNOPSIS

    use Acme::Yesterday;

=head1 DESCRIPTION

I'm an interesting introduction to this module.

=cut


use DateTime;

=head1 METHODS

=head2 some_method

    some_method();

Description of some_method().

=cut


sub some_method { ... }

1;

=head1 AUTHOR

Your Name <your@email>

=head1 COPYRIGHT

This program is free software; you can redistribute it
and/or modify it under the same terms as Perl itself.

Alternatively you can use Module::Starter to create a shell of a module for you.

Now for automated tests. At a minimum you should write a test that verifies that your module can even be loaded. Here’s how to do that:

mkdir t
vi t/00_use.t

The content of 00_use.t should be something like:

#!/usr/bin/perl -w
use strict;
use warnings;
use Test::More tests => 1;
BEGIN{ use_ok('Acme::Yesterday'); }

You’ll need to make a couple more files:

echo 'perldoc Acme::Yesterday' > README
echo '0.01 - First release.' > Changes

OK, now just sit back and let Module::Install do its work:

perl Makefile.PL
make dist
make disttest

Assuming your tests pass when you run `make disttest`, you’re set to put your module on CPAN. The above steps would have now created for you a Acme-Yesterday-0.01.tar.gz. This is the file that you need to upload to CPAN. In order to upload a distribution to CPAN you’ll need to get a pause account. Once your request has been approved you can login to pause, go to the upload page, and upload your tarball. Within an hour or two your new distribution will be availabe on CPAN.

Once you’ve done this you’ll want to clean up your distribution directory as running the various make steps leaves around some files you don’t need:

make distclean

Good luck!

Tagged as: